Walking route problem

[joeytalbot]

Circuity of walking routes is abnormally high in Ebbsfleet. This is why:

[joeytalbot]

The problem was that the 'nearest town centre' is being selected on the other side of the Thames.

[joeytalbot]

I've removed this walking route.

[Robinlovelace]

I've removed this walking route.

Good fix. Can you add a link to the line of code that fixes it? Thinking about phase II, wondering how we can generalise fixes for edge cases like this. Closing for now in any case, great work!

[joeytalbot]

 routes_walk_combined = routes_walk_cutdown %>% mutate(purpose = "commute")

if(route_walk_town$distance <= 6000) routes_walk_combined = bind_rows(routes_walk_combined, walk_town_cutdown %>% mutate(purpose = "town"))

This fixes it by removing any walking routes to town centres that are longer than 6km. The cycle routes are still in there (although in reality at Ebbsfleet they should go to a completely different town).

[joeytalbot]

https://github.com/cyipt/actdev/commit/67a911387a38d31fe4351d741d66922a189024a7

[Robinlovelace]

I guess you meant this line @joeytalbot ?

https://github.com/cyipt/actdev/blob/67a911387a38d31fe4351d741d66922a189024a7/code/scenarios-streamlined.R#L475

FYI you can copy permalinks to lines code as documented here, really handy feature: https://docs.github.com/en/github/managing-your-work-on-github/creating-a-permanent-link-to-a-code-snippet

[joeytalbot]

Yes that's the line, thanks.