cyipt / acton

Active Transport Options for New Developments
https://cyipt.github.io/acton/
GNU General Public License v3.0
3 stars 2 forks source link

Add support for dev version of api #52

Closed Robinlovelace closed 4 years ago

Robinlovelace commented 4 years ago

Enabling us to get queries such as: https://dev.planit.org.uk/api/applics/geojson?limit=250&pg_sz=250&bbox=-1.599425%2C53.768004%2C-1.477340%2C53.838354&app_state=Undecided&app_type=Full%2COutline&app_size=Large

Heads-up @mvl22 (we got this via streetfocus) and @aspeakman - any other search terms we can add to make this zoom-in on the Climate Innovation District and Allerton Bywater applications?

aspeakman commented 4 years ago

Do you mean in terms of setting the bbox more precisely? If so you can use the Planit Perimeter page

See https://dev.planit.org.uk/perimeter/-1.373595,53.738874,-1.342714,53.750244/ and https://dev.planit.org.uk/perimeter/-1.530522,53.786632,-1.519457,53.791044/

Press the Change button, adjust the boundary, then press the 'Show data' button and copy the bbox parameter from the resulting data page

Robinlovelace commented 4 years ago

Do you mean in terms of setting the bbox more precisely? If so you can use the Planit Perimeter page

No I meant which other API arguments. I guess size=large will be one of the queries that reduces the size of the result while keeping the applications we're interested in.

In hindsight 'zooming in' wasn't the most appropriate way of framing it.

aspeakman commented 4 years ago

Here is my current list of what is available:

app_size -> Size of the proposed development

app_state -> Decision status for the application

app_type -> Type of the application

Robinlovelace commented 4 years ago

Thanks @aspeakman see #48 for issues with app_size seemingly.

Robinlovelace commented 4 years ago

Closing as these query args are now in the R function get_planit_data():

app_size -> Size of the proposed development

app_state -> Decision status for the application

app_type -> Type of the application

mvl22 commented 4 years ago

Great, looks good. Nice.

https://github.com/cyipt/acton/blob/master/R/planit.R#L91-L93