search

cyjoelchen / php-sweph

PHP Extension for Swiss Ephemeris
Other
63 stars 29 forks source link

Change PHP interface to swe_cotrans() & swe_cotrans_sp(). #39

Closed kevindecapite closed 3 years ago

kevindecapite commented 3 years ago

Alois:

In C function swe_cotrans we allow for a 3-dimensional position vector which includes distance. That is fir the prigrammer's convenience. Distance is never changed in a rotational coordination transfirmation.

in the php implementation there are no vectors, but separate parameters lng, lat, dist in input and return. I suggest to drop dist from the parameter list, and from the return array.

Don't forget to update the inline documentation.

kevindecapite commented 3 years ago

After further comments, this issue is no longer valid.