search

cyjoelchen / php-sweph

PHP Extension for Swiss Ephemeris
Other
63 stars 29 forks source link

Issue/46 #47

Closed aloistr closed 3 years ago

aloistr commented 3 years ago

I am done with writing pods and making tests. Some functions may be untested, but not important ones. Please review and merge (this branch is already merged with branch documentation)

kevindecapite commented 3 years ago

I will review all of this during my afternoon. I am currently performing code reviews on another project all morning. Thank you.

aloistr commented 3 years ago

Good. It is quite impractical to have 9 hour time difference. My workday is over (7 pm) when yours just began.

kevindecapite commented 3 years ago

I know. That is one reason I started staying up later to have some overlap of hours with your early morning.

kevindecapite commented 3 years ago

I applied my additions so feel free to merge and delete this after you review the latest commits.