search

cyjoelchen / php-sweph

PHP Extension for Swiss Ephemeris
Other
63 stars 29 forks source link

Return extended values in swe_revjul(). #78

Closed kevindecapite closed 3 years ago

kevindecapite commented 3 years ago

Refs: https://github.com/cyjoelchen/php-sweph/issues/77

Do not merge yet. Ready for review.

I still need to make the calendar flag optional in swe_revjul() and swe_julday().

@aloistr How have you been generating the HTML and MD docs? I ran pod2html and pod2markdown but many differences were created beyond just the additional return values. Please see the "Update docs." commit for specifics. I am wondering if there are flags which you used to generate these files?

kevindecapite commented 3 years ago

@aloistr This is ready for your review. I added a test case to account for the exact scenario you described (feeding result of swe_julday() into swe_revjul()).

aloistr commented 3 years ago

Sorry, closed accidentally

Am 12.10.2021 um 21:21 schrieb Kevin DeCapite @.***>:

 @aloistr This is ready for your review. I added a test case to account for the exact scenario you described (feeding result of swe_julday() into swe_revjul()).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.