Closed kevindecapite closed 11 months ago
For some bizarre reason, only the swe_sol_eclipse.phpt
test was failing and only under the following conditions:
This means that the test was passing under all of these other conditions:
It was also passing in these test environments:
Given that, at the time of this comment, PHP 7.2 reached EOL in January of 2021 (and PHP 7.1 isn't even mentioned on the support timeline anymore), there is no reason to continue to support this older version of PHP.
For now, I am removing all versions of PHP 7 except for the latest (7.4), which did reach EOL as of January of 2023.
These tests were failing on ARM chipsets. Reducing the precision resolved the issue due to what I assume are minor calculation discrepancies between different architectures.
The
swe_heliacal_ut()
test was especially problematic. Removing the usage of theSE_HELFLAG_OPTICAL_PARAMS
flag bit resolved the issue. I've been unable to create a passing test using this flag bit, however, which may mean that this flag is not properly supported by this extension.Here's a swetest example which uses observer data:
When I set this flag bit and the corresponding observer data in the PHP tests, I see very different results:
Refs: