search

cykod / Quintus

HTML5 Game Engine
http://html5quintus.com
GNU General Public License v2.0
1.41k stars 401 forks source link

Bugfix #109

Closed taozeyu closed 10 years ago

ghost commented 10 years ago

Please add a description telling what the bug is and explain your changes. Thanks.

mpkorstanje commented 10 years ago

A first glance explanation. The change in lib/quintus_scenes.js notifies an item that is has been removed from the scene by triggering removed on that item. This in itself is a nice feature to have.

I'm guessing that he's using the removed event as a queue to remove the physics component which will then clean up after itself. This triggers an exception as parent is undefined, and should obviously be stage.

@Bitshock, if none is forthcoming I'll have a better look.

ghost commented 10 years ago

@cykod What do you think about this? I think this shouldn't be merged, unless you believe this represents a solution for a particular problem.

cykod commented 10 years ago

Closing as I don't think the removed fix does anything - will add in the fix to physics manually