search

cykreng / Enterprise-Scale-AppService

8 stars 9 forks source link

Workflow #56

Closed cykreng closed 2 years ago

cykreng commented 2 years ago

@torokzs - couple questions for you:

  1. For networking.bicep - is there a reason we're using the 2020/7/1 API version vs. the more recent one (2021/2/1) in main for vnetHub , vnetHubPeer, vnetSpokePeer? Is there a reason why we commented out creation of the CICD agent subnet?
  2. For ase.bicep - I initially left zoneRedundant in comments, is that still the case that it's not supported by bicep?
torokzs commented 2 years ago

@torokzs - couple questions for you:

  1. For networking.bicep - is there a reason we're using the 2020/7/1 API version vs. the more recent one (2021/2/1) in main for vnetHub , vnetHubPeer, vnetSpokePeer? Is there a reason why we commented out creation of the CICD agent subnet?
  2. For ase.bicep - I initially left zoneRedundant in comments, is that still the case that it's not supported by bicep?

1a. I didn't modify API version, it should work, we have to test. 1b. I've moved CICD subnet creation next to the other subnet creations. The reason behind is this bug: https://githubmemory.com/repo/Azure/bicep/issues/4653

  1. Didn't touch this part either.