cylammarco / ASPIRED

Automated SpectroPhotometric Image REDuction (ASPIRED)
https://aspired.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
30 stars 4 forks source link

Support user supplied wavelength calibrated standard #19

Closed cylammarco closed 4 years ago

cylammarco commented 4 years ago

Multiple observations may depend on the same set of standard observation for calibration, it is massively inefficient if the standard has to be recalibrated in each reduction.

cylammarco commented 4 years ago

This will be possible if OneDSpec() initialises without doing anything. The data can be added with e.g. add_spec('science', pixwave=None, wavecal=False...), add_wavecal('science+standard'...) and add_standardflux(StandardFlux...).

This way the add_spec can handle wavelength calibrated science and standard, the wavelength can be provided with the optional pixwave list/array. This pixwave can also allow user to supply the pixel list that accounts for the chip gaps if a long slit spectrum is taken across multiple chips. This will also solve #20.

cylammarco commented 4 years ago

Fixed in https://github.com/cylammarco/ASPIRED/commit/554ba020c5502b9bd2ca90d44ace489963da0f6b