search

cylammarco / ASPIRED

Automated SpectroPhotometric Image REDuction (ASPIRED)
https://aspired.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
30 stars 4 forks source link

pip struggles to install ASPIRED #6

Closed cylammarco closed 3 years ago

cylammarco commented 4 years ago

Reported from Ilknur:

pip install git+https://github.com/cyalmmarco/ASPIRED.git@dev installs the dist-info but not the package

however git clone https://github.com/cyalmmarco/ASPIRED.git@dev then pip install -e ASPIRED works

Is it a problem with pip or with setup.py? Probably the latter?

cylammarco commented 4 years ago

Should also sort out plotly-orca dependency issue here. It should be an optional dependency.

cylammarco commented 4 years ago

SpectRes v2.1.1 fixed the wavelength coverage problem, it is now included in the setup.py which installs the package from pypi. Waiting on RASCAL release before looking into this again.

cylammarco commented 4 years ago

Dependency handling should be simpler because of the recent updates with SpectRes and RASCAL:

SpectRes v2.1.1 has fixed the last pixel bug and can handle new wavelength range outside of the old wavelength range, dependency on a forked version is no longer needed.

RASCAL master branch is usable now.

I will do more build test before closing.

cylammarco commented 4 years ago

Added MANIFEST.in, which solved some of the problem.