search

cylammarco / ASPIRED

Automated SpectroPhotometric Image REDuction (ASPIRED)
https://aspired.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
30 stars 4 forks source link

`set_properties()` in `TwoDSpec()` should scan the header #97

Closed cylammarco closed 2 years ago

cylammarco commented 2 years ago

If gain, readnoise, airmass, and seeing are not explicitly provided, ASPIRED should attempt to extract the values from the header. But if it is no longer a default value, this SHOULD NOT be overwritten. A TwoDSpec object should track whether a value is explicitly provided, for example, set_airmass() is explicitly used before calling set_properties(), such that it know whether such information should be attempted to be extracted from the header, while the manually provided value will not get overwritten.

cylammarco commented 2 years ago

Fixed in 0.4.6 and dev-0.5.X