cylc / cylc-admin

Project planning for the Cylc Workflow Engine.
https://cylc.github.io/cylc-admin/
GNU General Public License v3.0
5 stars 13 forks source link

add status page #167

Closed oliver-sanders closed 1 year ago

oliver-sanders commented 1 year ago

This can be used to automatically pick compatible Cylc versions for installation for CI in the Cylc component repositories via release-actions - https://github.com/cylc/release-actions/pull/46

Screenshot from 2023-02-03 13-24-10

oliver-sanders commented 1 year ago

For some reason this action doesn't show up on my fork when pushed to master - https://github.com/oliver-sanders/cylc-admin/actions

Not sure why, I've probably done something badly wrong, not sure how to test the action without it.

MetRonnie commented 1 year ago

Do you need to enable it in the repo settings?

oliver-sanders commented 1 year ago

I think it's enabled?

Screenshot from 2023-02-03 15-18-40

MetRonnie commented 1 year ago

Only thing I can think of is to push a dummy commit to master to try and get it to trigger the Actions workflow for the first time

oliver-sanders commented 1 year ago

Good idea, sadly didn't do the trick.

oliver-sanders commented 1 year ago

It's not a complex action and the script can be tested manually so can always fix in situ if needed.

MetRonnie commented 1 year ago
# Note: This action deletes its previous commits so the nightly build history
# is not preserved and does not require housekeeping.

Doesn't look like it is doing this to me

I see you've now removed that comment, but isn't self-housekeeping desirable?

oliver-sanders commented 1 year ago

isn't self-housekeeping desirable?

That would require force pushing.

That comment was accidentally copied from a cylc-doc action where each "push" contains a complete build of the docs which is substantial. Each of the commits here is just a couple of lines of JSON and Markdown so much less concerning.

oliver-sanders commented 1 year ago

IMO having nightly commits piling up would be a bit messy,

We shouldn't actually get "nightly" commits because the status page should only change when the branches get updated. Otherwise the page should build exactly the same every time so there will be nothing to commit, so nothing will get pushed up. We should only get one commit each time we change the branches, typically once per minor release of cylc-flow which will be a manageable number.

I think workflow should probably skip the "push changes" part if there's nothing to commit incase the commit or push return non-zero because of this?

Note, the cron schedule isn't actually necessary here, the only reason I added it was to have some indication if the action breaks.