search

cylc / cylc-admin

Project planning for the Cylc Workflow Engine.
https://cylc.github.io/cylc-admin/
GNU General Public License v3.0
5 stars 13 forks source link

proposal set: fix small error #183

Closed oliver-sanders closed 1 year ago

oliver-sanders commented 1 year ago

Sorry, spotted a small error in the cylc set proposal.

cylc set --pre=all is NOT equivalent to trigger as outlined in "7. Spawning parentless tasks". It's more equivalent to Cylc 7's insert.

hjoliver commented 1 year ago

The way I put it in the cylc set PR is:

 Setting prerequisites contributes to a task's readiness to run and promotes it
to the active window where any clock and xtriggers will become active.

Which in fact applies to setting any or all prerequisites.

I'll go back and compare my wording (in the PR) to yours (in the proposal) to see what's clearest ...

hjoliver commented 1 year ago

It's more equivalent to Cylc 7's insert.

Except unlike insert, in Cylc 8 --pre=all IS equivalent to trigger IF there are no non-prerequisite constraints active.

hjoliver commented 1 year ago

So I'll merge this, but the CLI help might still require a bit extra to fully explain.