graphviz: upgrade to latest

cylc / cylc-doc

Documentation (User Guide, Cheat Sheets, etc.) for the Cylc Workflow Engine.

https://cylc.github.io/cylc-doc/

GNU General Public License v3.0

9 stars 19 forks source link

graphviz: upgrade to latest #247

Open oliver-sanders opened 3 years ago

oliver-sanders commented 3 years ago

Due to a graphviz issue we pinned our actions to Ubuntu 18 in https://github.com/cylc/cylc-doc/pull/246.

Once the issue is resolved we should unpin and update (may need to install via Conda if Ubuntu is slow off the mark).

MetRonnie commented 3 years ago

For reference:

Ubuntu 18 has graphviz 2.40.1-2, which is fine.
Currently Ubuntu 20 has graphviz 2.42.2-3build2, which has the diagram overflow bug #209
According to https://gitlab.com/graphviz/graphviz/-/issues/1855, graphviz 2.44.1 also has the same bug

oliver-sanders commented 2 years ago

The linked GraphViz issue has now been closed, hopefully that'll do it (waiting for release).

MetRonnie commented 2 years ago

I have noticed it is difficult to read green text in graphs on the GH Actions deployed docs (Ubuntu 18, graphviz 2.40.1-2)

This is not the case locally with graphviz 2.50.0

(ubuntu-latest is still 20 at the moment, so still graphviz 2.42.2-3build2.)

P.S. why isn't pygraphviz a dependency of cylc-doc?

oliver-sanders commented 2 years ago

why isn't pygraphviz a dependency of cylc-doc?

Because we don't use pygraphviz. We do use Graphviz via a Sphinx plugin, however you can't pip install that (note that pygraphviz does not provide graphviz).

oliver-sanders commented 2 years ago

I have noticed it is difficult to read green text in graphs on the GH Actions deployed docs

We should probably hardcode these colours (we can use 8-bit hex values) if there are any issues like this.

MetRonnie commented 2 years ago

Because we don't use pygraphviz. We do use Graphviz via a Sphinx plugin, however you can't pip install that (note that pygraphviz does not provide graphviz).

Then why do we install it in https://github.com/cylc/cylc-doc/blob/1fa14ffa74c489ec3e1b52f6fbab8cc6a95d3132/.github/actions/install-dependencies/action.yml#L27-L30

oliver-sanders commented 2 years ago

No idea.

It's not used by the cylc-doc code directly, it's not used by the cylc-sphinx-extensions code directly, it's not used by the Sphinx graphviz extension.

MetRonnie commented 2 years ago

(Removed pygraphviz in #491)

MetRonnie commented 2 years ago

ubuntu-22.04 still has graphviz 2.42.2-6 on apt