cylc / cylc-doc

Documentation (User Guide, Cheat Sheets, etc.) for the Cylc Workflow Engine.
https://cylc.github.io/cylc-doc/
GNU General Public License v3.0
9 stars 19 forks source link

job runners: document handler interface #594

Closed oliver-sanders closed 1 year ago

oliver-sanders commented 1 year ago

Sibling: https://github.com/cylc/cylc-flow/pull/5389

The documentation for the job runner handler interface is poor but I found a docstring in cylc-flow with valuable information which wasn't being auto-documented.

I'm not taking the time for a full documentation re-write right now (no time) so this is mostly just what was already there reformatted and auto documented. The important thing is to expose this documentation as there are people trying to write handlers ATM.

@hjoliver if you get a chance to skim this that would be great.

wxtim commented 1 year ago

You'll want to add the following the dictionaries

You could choose to add ret to the dictionary, or change the variable ret_code in the example code to return_code.

oliver-sanders commented 1 year ago

What! The spellchecker is testing argument names and return types in autogenerated code reference!!!

wxtim commented 1 year ago

What! The spellchecker is testing argument names and return types in autogenerated code reference!!!

The spellchecker is remarkably unsophisticated, unfortunately.

oliver-sanders commented 1 year ago

Done.

We currently have a user waiting flying blind without the benefit of these docs so could do with getting this into the nightly builds quickly.

wxtim commented 1 year ago

Reverted - I missed the fact that this is still not building correctly. :(

oliver-sanders commented 1 year ago

Wait, hang on, @wxtim is this in or not?