cylc / cylc-flow

Cylc: a workflow engine for cycling systems.
https://cylc.github.io
GNU General Public License v3.0
328 stars 92 forks source link

mypy: python 3.10+ #5736

Open oliver-sanders opened 11 months ago

oliver-sanders commented 11 months ago

Mypy appears to be raising false positives in imported code for Python 3.10+, so currently, we're only running it for Python 3.9.

We will need to address this going forward.

The problem:

Because no_silence_site_packages=false (the default) I wouldn't expect any errors from imported code anyway?

See https://github.com/cylc/cylc-flow/pull/5735

MetRonnie commented 5 months ago

https://github.com/python/mypy/issues/9972

I don't think we can do anything about this

oliver-sanders commented 5 months ago

Ok, I guess we'll stick with 3.9 for linting until we are able to drop 3.7 support. Bit of a pain for development, but easy to achieve in CI.