Closed oliver-sanders closed 4 days ago
I commented on this in the recent workflow-state overhaul PR, here:
https://github.com/cylc/cylc-flow/pull/5809#issuecomment-2149481816
Initially I did automatically convert transient statuses to outputs, but backed out of that for the following reasons:
:running
(status) and gets :started
(output)Maybe that was the wrong call, but @MetRonnie seemed satisfied at the time.
The CLI upgrade advise tells you to upgrade an existing message poller into a status poller:
Definitely not deliberate.
Suggest:
Agreed on all counts.
The workflow-state command defaults to polling task status rather than task trigger.
The CLI upgrade advise tells you to upgrade an existing message poller into a status poller:
This is inconsistent with the xtrigger upgrade advice which tells you to use
is_message=True
:The CLI advice becomes a problem in the case of the
submitted
output. Becausesubmitted
is a status, it defaults to status polling. However, the submitted status is transitory so this test is not safe.Suggest: