Fix potential type error & a few small mistakes

MetRonnie commented 2 months ago

Small change with no associated issue

Check List

[x] I have read CONTRIBUTING.md and added my name as a Code Contributor.
[x] Contains logically grouped changes (else tidy your branch by rebase).
[x] Does not contain off-topic changes (use other PRs for other changes).
[x] No dependency changes
[x] tests are not needed
[x] No changelog entry as not known bug
[x] No docs needed
[x] If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

MetRonnie commented 2 months ago

Another similar mistake spotted for the TaskPool.spawn_task() method (not to be confused with TaskEventsManager.spawn_func() mentioned before): https://github.com/cylc/cylc-flow/blob/f30f0c289e1cb803808df4f9131424c23e00b71e/cylc/flow/task_pool.py#L1657-L1664

flow_wait is incorrectly passed to the force argument in 2 places:

hjoliver commented 2 months ago

(Ah, yeah I found that in my group-trigger branch, which I haven't exposed to you all yet)

MetRonnie commented 2 months ago

Can bump to 8.3.5 if needed

cylc / cylc-flow