cylc / cylc-flow

Cylc: a workflow engine for cycling systems.
https://cylc.github.io
GNU General Public License v3.0
335 stars 94 forks source link

tui: fix task state filters #6390

Closed oliver-sanders closed 1 month ago

oliver-sanders commented 1 month ago

Test this with any odd workflow that contains families. Before this change task state filtering kinda worked, however, sometimes tasks were erroneously filtered out (due to the family state not matching the task state) and some empty families/cycles were left in erroneously.

Check List

oliver-sanders commented 1 month ago

Mark spotted two issues:

  1. Traceback when running the complex workflow (solved).
  2. Non-waiting jobs occasionally appearing when filtering for waiting tasks (replicated but not solved). This seems to be a momentary flicker that quickly vanishes.
oliver-sanders commented 1 month ago

I can't get a handle on issue (2). I have only very occasionally seen filtering go wrong and always a quick flash that quickly corrects itself.

Less broken is an improvement.

wxtim commented 1 month ago

Less broken is an improvement.

I'd be happy to accept this PR on that basis? @markgrahamdawson ?