cylc / cylc-flow

Cylc: a workflow engine for cycling systems.
https://cylc.github.io
GNU General Public License v3.0
335 stars 94 forks source link

GH actions: re-run failed Tui tests #6430

Closed MetRonnie closed 1 month ago

MetRonnie commented 1 month ago

The Tui integration tests are flakily failing quite a lot on GH Actions, so I've made it so that they re-run any failures.

Tried re-triggering several times, couldn't get it to fail 🤷‍♂️. Perhaps splitting it off from the other integration test run was enough.

Check List

oliver-sanders commented 1 month ago

I haven't managed to get a handle on the Tui failures, they don't make much sense to me and are extremely hard to replicate.

Tried re-triggering several times, couldn't get it to fail

Are you suggesting the retry (pytest || pytest) isn't necessary, just splitting it out?

Might be worth looking into this:

https://pypi.org/project/pytest-retry/

MetRonnie commented 1 month ago

Are you suggesting the retry (pytest || pytest) isn't necessary, just splitting it out?

Yes, possibly

Might be worth looking into this: https://pypi.org/project/pytest-retry/

Can do but I just wanted to quickly bash this change out

MetRonnie commented 1 month ago

Merging with 1 approval as these failures are rather irritating. We can tweak this in future