Expand comma separated lists in `global.cylc:[install][symlink dirs]` - Githubissues

cylc / cylc-flow

Cylc: a workflow engine for cycling systems.

https://cylc.github.io

GNU General Public License v3.0

335 stars 94 forks source link

Expand comma separated lists in `global.cylc:[install][symlink dirs]` #6475

Closed wxtim closed 18 hours ago

wxtim commented 2 weeks ago

From an issue raised by @dpmatthews

Allow comma separated lists of install targets in global.cylc:[install][symlink dirs][__MANY__]

@oliver-sanders tagged for code review, @dpmatthews for concept review.

Check List

[x] I have read CONTRIBUTING.md and added my name as a Code Contributor.
[x] Contains logically grouped changes (else tidy your branch by rebase).
[x] Does not contain off-topic changes (use other PRs for other changes).
[x] Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
[x] Tests are included (or explain why tests are not needed).
[x] Changelog entry included if this is a change that can affect users
[x] Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
[x] If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

MetRonnie commented 1 week ago

Slightly cheekily, I've targeted 3.8.x not master. Although this is a feature, it's for sysadmins not end-users, and I have very high confidence that it won't break anything.

Is this still the case? Currently opened against master and not assigned a milestone. Did Dave request it be added to 8.3.7?

wxtim commented 1 week ago

Currently opened against master and not assigned a milestone.

Not intentionally

Did Dave request it be added to 8.3.7?

It's blocking some stuff Dave wants to do - I think it's a bug from his point of view.

dpmatthews commented 1 week ago

It's blocking some stuff Dave wants to do - I think it's a bug from his point of view.

No urgency as far as I'm concerned and certainly not a bug.

wxtim commented 1 week ago

It's blocking some stuff Dave wants to do - I think it's a bug from his point of view.

No urgency as far as I'm concerned and certainly not a bug.

Changed to 8.4.0 milestone for less cheeky.

hjoliver commented 4 days ago

(Took a quick look, but I think @MetRonnie is about to approve this so I'll leave it be)

MetRonnie commented 1 day ago

Sorry, got another one: https://github.com/wxtim/cylc/pull/69

hjoliver commented 18 hours ago

Two approvals.