cylc / cylc-textmate-grammar

TextMate grammar for Cylc workflow configuration files
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Add everything [not actually merged!] #1

Closed MetRonnie closed 4 years ago

oliver-sanders commented 4 years ago

For interest here's another repo which is going the same way about this:

https://github.com/microsoft/TypeScript-TmLanguage

oliver-sanders commented 4 years ago

Rolled a TextMate bundle using this grammar and tested in TextMate, look good:

one

Some whitespace is marked as error:

two

MetRonnie commented 4 years ago

@oliver-sanders I think it would make sense to tackle this after merging the PR, as then I will be able to include the repo as a submodule in the vscode-cylc repo, so I can resume developing. Created an issue for it #3

oliver-sanders commented 4 years ago

(sorry forgot to submit the review yesterday)

oliver-sanders commented 4 years ago

Evaluating against the native TextMate here's where this Grammar stands:

Support is pretty good, especially for a first pass, good job with the ISO8601 work, I wan't expecting anything so advanced, the Pygments lexer doesn't do anything so fancy.

The only things which aught to be fixed before rolling this out are:

3-1 1