cylc / cylc-ui

Web app for monitoring and controlling Cylc workflows
https://cylc.github.io
GNU General Public License v3.0
37 stars 27 forks source link

toolbar: add n-window-selector #1755

Closed oliver-sanders closed 7 months ago

oliver-sanders commented 7 months ago

n-window-changing

Check List

oliver-sanders commented 7 months ago

@MetRonnie, this setting is preserved when you navigate back, however, I have not done anything to achieve this. Should it be implemented differently or is this ok? (note the n=1 default comes from cylc-flow not cylc-ui)

MetRonnie commented 7 months ago

It's preserved because it's querying it, right?

oliver-sanders commented 7 months ago

Derp, yes, it's getting the n-window extent from the returned data :facepalm:

oliver-sanders commented 7 months ago

As a true end-to-end feature (i.e. flow-uis-ui-uis-flow) it's a right pain to test. I had a look a testing, at the unit test level you end up testing vue watchers and at the e2e level, you end up testing the Vuetify Select API.