cylc / cylc-ui

Web app for monitoring and controlling Cylc workflows
https://cylc.github.io
GNU General Public License v3.0
37 stars 27 forks source link

Simplify mutation menu #1775

Closed MetRonnie closed 4 months ago

MetRonnie commented 5 months ago

By figuring out how to use VMenu better I was able to drop a fair amount of cruft.

We were originally using VMenu but through various attempts to get it to behave the way we want (e.g. #927, #1269) I ended up re-implementing some of the behaviour manually (e.g. click-outside behaviour).

It turns out the key to using VMenu and getting it to behave the way we want is not too difficult:

Update: also renamed the v-cylc-object directive to v-command-menu as that is more descriptive IMO

Check List

MetRonnie commented 4 months ago

Latest change should make it immune to that kind of thing

oliver-sanders commented 4 months ago

Fixed.

MetRonnie commented 4 months ago

@markgrahamdawson Tagged you for review. If you've not come across the mutation menu code before, it might be best for me to explain how it works before you review

MetRonnie commented 4 months ago

I've also renamed the v-cylc-object directive to v-command-menu as that is more descriptive IMO