Fix router issues - Githubissues

cylc / cylc-ui

Web app for monitoring and controlling Cylc workflows

https://cylc.github.io

GNU General Public License v3.0

37 stars 27 forks source link

Fix router issues #1794

Closed MetRonnie closed 6 months ago

MetRonnie commented 6 months ago

Set page title per-route rather than per-view
- Multiple views may be included in a page, so the previous approach was flawed
- This removes a blocker from #1785 (for some reason that Vuetify update has uncovered this flaw)
Improve router error handling & tidy

Address this warning that has been around for ages:

[Vue Router warn]: <router-view> can no longer be used directly inside <transition>

Removes @unhead/vue dependency as it is a bit overkill for just setting the page title, which can be done simply using document.title = title

Check List

[x] I have read CONTRIBUTING.md and added my name as a Code Contributor.
[x] Contains logically grouped changes (else tidy your branch by rebase).
[x] Does not contain off-topic changes (use other PRs for other changes).
[x] Tests are included
[x] Changelog not needed as not user-facing