cylc / cylc-ui

Web app for monitoring and controlling Cylc workflows
https://cylc.github.io
GNU General Public License v3.0
37 stars 27 forks source link

No feedback if you execute a mutation for a cyclepoint/task that is gone from the UI #639

Open kinow opened 3 years ago

kinow commented 3 years ago

Describe the bug

At the moment you can click on items in the UI tree to display a mutations form. The form contains entries that you can then click to trigger mutations in the backend.

If a task or cyclepoint is short-lived, or if it is about to disappear, the mutations form is not removed.

And if you click on Hold for example, there is no feedback in the UI, nor in the browser console. In the Cylc UIS logs I can see a warning saying that the task does not exist. But it would be nice to have some visual feedback.

Release version(s) and/or repository branch(es) affected?

master

Steps to reproduce the bug

See description.

Expected behavior

A visual feedback.

Screenshots

Additional context

I think we have a related issue here or in Cylc UIS about displaying mutations/graphql errors, but I couldn't find it, so logging this new one so I don't forget it :+1:

Pull requests welcome! This is an Open Source project - please consider contributing a bug fix yourself (please read CONTRIBUTING.md before starting any work though).

hjoliver commented 3 years ago

This is a tricky one.

Part of the solution is getting feedback from the scheduler about command completion rather than just the "command queued" message (I think we have an issue for that somewhere), because for some commands it doesn't actually matter if the task is gone from the UI. For commands where that does matter, we could presumably have a UI-driven solution.

oliver-sanders commented 3 years ago

I think: