search

cylc / cylc-ui

Web app for monitoring and controlling Cylc workflows
https://cylc.github.io
GNU General Public License v3.0
37 stars 27 forks source link

aoft: expand cycles/families in mutations to the visible selection #686

Open oliver-sanders opened 3 years ago

oliver-sanders commented 3 years ago

See https://github.com/cylc/cylc-flow/pull/4238#pullrequestreview-677164798

Tui: sibling https://github.com/cylc/cylc-flow/issues/4246

Task pool commands (e.g. cylc hold) can only apply pattern matching to the n=0 window. This means that cylc hold <family>.<cycle> or cylc hold '*.<cycle>' don't work if <cycle> is not in the n=0 window.

The practical upshot of this is if you try to hold a family or cycle of tasks that are in the n>0 window, then nothing happens.

To get around this problem we should expand the cycle/family to the full list of tasks visible in the UI.

oliver-sanders commented 3 years ago

Adding the bug label as this will cause confusion for users.

This may require a little thought, we don't currently have the ability to expand a family/cycle to its constituent tasks so I think this is closely related to #434.

There is also the problem of knowing when to treat a cycle point as a cycle point and when to expand it to a list of IDs. It may be easier to attempt this after https://github.com/cylc/cylc-flow/pull/4238.