cylc / cylc-uiserver

A Jupyter Server extension that serves the cylc-ui web application for monitoring and controlling Cylc workflows.
https://cylc.org
GNU General Public License v3.0
15 stars 18 forks source link

`cylc play` service: don't unset `$CYLC_ENV_NAME` if no version specified #533

Closed MetRonnie closed 10 months ago

MetRonnie commented 10 months ago

Follow-up to #525

Unfortunately it broke ~job submission~ cylc play if you were using a ~non-standard Cylc environment name (i.e. not cylc-8.X.Y)~ Cylc environment name that didn't match cylc-8.X.Y exactly, and didn't specify a version in the cylc play-edit form

Check List

dpmatthews commented 10 months ago

a non-standard Cylc environment name (i.e. not cylc-8.X.Y)

The naming convention recommended in the wrapper script is cylc-8.X.Y-Z so this doesn't just affect non-standard names