Add extra options to task left click menu

cylc / cylc-uiserver

A Jupyter Server extension that serves the cylc-ui web application for monitoring and controlling Cylc workflows.

https://cylc.org

GNU General Public License v3.0

15 stars 18 forks source link

Add extra options to task left click menu #552

Closed ColemanTom closed 9 months ago

ColemanTom commented 9 months ago

Problem

Problem is too strong a word. I'm finding, when I have a task expanded, showing the numbered tasks, I bring up the numbered item if I want to do something like Kill the task.

Proposed Solution

Add some extra options so they are in both the top level task menu and the individual task menu, where it makes sense. For example, Kill and Poll. Logs already appears in both menu's so this would (I imagine) be a small extension?

hjoliver commented 9 months ago

FYI, the "numbered tasks" are "jobs". As in, a task can submit multiple jobs.

I presume your yellow highlighter has changed running job 5 (blue) to green (which is supposed to represent a succeeded job).

To explain the status quo, when you want to poll or kill a job, you really target a specific task instance (<cycle>/<name>) and the scheduler does it if the task currently has an active job.

That said, I think it's a reasonable suggestion to add poll, and kill to the menu for running jobs, but note that it would only affect the menu for the latest job, and only while it is still running. And other than "view logs", there aren't any other commands that target specific jobs, running or finished.

ColemanTom commented 9 months ago

Sorry about the terminology and my lazyness not changing from highlight to a pen to circle it like I had originally thought to do. Yes, it was a running job.

And yes, I only thought for the latest active job as you describe. Thanks for clarifying what I meant.

oliver-sanders commented 9 months ago

Hi, I'm not sure what commands you're expecting to see in which menu.

There are some commands which are applicable to tasks but not jobs (e.g. set-outputs). These will not be added to the job menu.
There are some tasks commands which may be applicable to jobs but don't appear in the job menu at present for technical reasons.

hjoliver commented 9 months ago

Hi, I'm not sure what commands you're expecting to see in which menu.

See my comment above - I said it could only be poll and kill, and only for the latest job and only while it active - and @ColemanTom agreed.

oliver-sanders commented 9 months ago

Right. Currently we don't have the ability to poll or kill a specific job as these commands are issued against the task.

When this cylc-flow issue is solved, the poll and kill mutations will automatically show up in the job menu in the GUI (the command lists are auto generated): https://github.com/cylc/cylc-flow/issues/5950

Closing this as transferred to https://github.com/cylc/cylc-flow/issues/5950