cylc / cylc-uiserver

A Jupyter Server extension that serves the cylc-ui web application for monitoring and controlling Cylc workflows.
https://cylc.org
GNU General Public License v3.0
15 stars 18 forks source link

config: configure default websocket ping interval #586

Open oliver-sanders opened 7 months ago

oliver-sanders commented 7 months ago

To review, you might want to jam a debugger into this method:

https://github.com/tornadoweb/tornado/blob/f399f40fde0ae1b130646db783a6f79cc59231b2/tornado/websocket.py#L1540-L1557

Or mess around with the ping timeout.

Check List

oliver-sanders commented 6 months ago

This configuration appears to cause the connection to be closed with each ping, investigation required.

oliver-sanders commented 6 months ago

It looks like there is an issue with the implementation of ping_timeout: https://github.com/tornadoweb/tornado/issues/3258

Looks like an easy fix, having a crack.

oliver-sanders commented 6 months ago

This will require an upstream fix: https://github.com/tornadoweb/tornado/pull/3376