Open oliver-sanders opened 7 months ago
This configuration appears to cause the connection to be closed with each ping, investigation required.
It looks like there is an issue with the implementation of ping_timeout: https://github.com/tornadoweb/tornado/issues/3258
Looks like an easy fix, having a crack.
This will require an upstream fix: https://github.com/tornadoweb/tornado/pull/3376
To review, you might want to jam a debugger into this method:
https://github.com/tornadoweb/tornado/blob/f399f40fde0ae1b130646db783a6f79cc59231b2/tornado/websocket.py#L1540-L1557
Or mess around with the ping timeout.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.