cylc / cylc-uiserver

A Jupyter Server extension that serves the cylc-ui web application for monitoring and controlling Cylc workflows.
https://cylc.org
GNU General Public License v3.0
15 stars 18 forks source link

Don't protect static assets from XSRF #592

Closed minrk closed 4 months ago

minrk commented 5 months ago

JupyterHub 4.1 applies XSRF checks to authenticated GET requests, which is not necessary for static assets. It would be a valid alternative to not authenticate these requests.

This solves the static asset request, described in https://github.com/jupyterhub/jupyterhub/issues/4800

The userprofile request must be addressed in https://github.com/cylc/cylc-ui

Check List

MetRonnie commented 5 months ago

@oliver-sanders I think this should be on 1.4.5 milestone?

oliver-sanders commented 5 months ago

(we will probs skip 1.4.5 since we are near ready for 1.5.0 release but we can merge it through as normal)

minrk commented 5 months ago

I added one more commit based on https://github.com/jupyterhub/jupyterhub/issues/4800#issuecomment-2092945342 to ensure the xsrf cookie is set on GET /cylc/