cylc / cylc-uiserver

A Jupyter Server extension that serves the cylc-ui web application for monitoring and controlling Cylc workflows.
https://cylc.org
GNU General Public License v3.0
15 stars 18 forks source link

Log any cat-log failure when listing log files #607

Closed MetRonnie closed 4 months ago

MetRonnie commented 4 months ago

When trying to set up cylc hub, Dave encountered cat-log problems which were swallowed by the UIS. This PR ensures any such errors are logged.

Check List

MetRonnie commented 4 months ago

I'm inclined to say no automated tests are needed for this

MetRonnie commented 4 months ago

I realised that there are a few ways cat-log will exit non-zero when navigating in the UI (e.g. navigating to /log/non-exist), so have settled for just logging the stderr and returning an empty list as before