Last task in workflow doesn't update to succeeded in graph GUI

[jfrost-mo]

Description

After a workflow reaches its final cycle point, and the last task completes, the reported state in the graph view of the GUI still claims the task to be running, when it is not.

Reproducible Example

Run a workflow, opening it in cylc gui on the graph view. Once the workflow reaches its final cycle point, and the last task completes, observe the reported state of that task on the graph. It will be left in a running state, despite actually having succeeded.

Expected Behaviour

The task in the GUI should be marked as succeeded.

[Fraetor]

An example. Note the workflow is stopped after having completed, but the task still claims to be running.

[MetRonnie]

Duplicate of cylc/cylc-ui#1756

[oliver-sanders]

I think that's a different issue.

@jfrost-mo, if you switch back to the tree view, the task should still be visible there too, what state is it in?

[MetRonnie]

I can reproduce with a simple workflow.

if you switch back to the tree view, the task should still be visible there too, what state is it in?

The workflow completed so the tree view is empty after shutdown

[oliver-sanders]

Good point, would need an incomplete task to test the graph view against the tree view.

[MetRonnie]

Ok so not a duplicate because cylc/cylc-ui#1756 is just about clearing the graph view but the bug here is we are missing a delta update for the final state of the task before it is pruned

[jfrost-mo]

Clearing the graph would resolve this issue too, though I do personally find it quite disconcerting that the workflow finished state is just an empty window. Maybe some kind of graphic to indicate "Congratulations, your workflow finished." I see there is Issue https://github.com/cylc/cylc-ui/issues/332 for this.

[oliver-sanders]

That's the plan, we just haven't managed to get around to it!