search

cylc / cylc.github.io

Source files for the Cylc Workflow Engine web site.
https://cylc.github.io/
GNU General Public License v3.0
5 stars 9 forks source link

Responsive Design Changes #38

Closed prasannavijayan closed 4 years ago

hjoliver commented 4 years ago

Thanks @prasannavijayan :+1: Sorry for the slow response; it has been a long weekend/ vacation here.

hjoliver commented 4 years ago

@prasannavijayan - can you explain how to publish this to GitHub Pages? (should it just work, or do I need to change something first? I just tried via my repo fork, but the published page lost all formatting).

prasannavijayan commented 4 years ago

@hjoliver It will start working automatically once you merge with the master branch.

As you said the formatting lost when you tried to publish page in your fork it's because you need to update the _config.yml file with the respective baseURL if it's something like <URL>/blog.

hjoliver commented 4 years ago

I'm testing this by publishing to GitHub Pages on my fork, but some relative URLs are not working.

The browser goes to 

https://hjoliver.github.io/assets/screenshots/gcylc-graph-dot.png

Instead of 

https://hjoliver.github.io/cylc.github.io/assets/screenshots/gcylc-graph-dot.png
                           ^^^^^^^^^^^^^^

Possibly this would affect the main site which doesn't have the first URL component ( https://cylc.github.io/screenshots/gcylc-graph-dot.png for the example above) but it would be good to get this right anyway.

hjoliver commented 4 years ago

Hmm, we don't really need to generate the screenshots page by iterating over yml data (can't use the jekyll relative URL filter in there, I think). I'll try changing that...

hjoliver commented 4 years ago

I added this to my config (but not sure if it's needed):

# _config.yml
url: "https://hjoliver.github.io"
baseurl: "/cylc.github.io"
hjoliver commented 4 years ago

@prasannavijayan - I would like to get this in quickly so I can make some updates to the site content. You have done the hard part, and the issues I found are probably due to some quirk of GitHub Pages (or how I'm using it). If you don't want to deal with that, I can take over your branch and get it working on GitHub Pages before merging to master (your name will still be on the commits of course). Let me know if you would prefer that, or want to finish it off yourself (and sorry we didn't get it done in time for Hacktoberfest! :grimacing: )

prasannavijayan commented 4 years ago

@hjoliver Hi, I have done the changes as requested. Sorry, I couldn't work on this on time. If you want more changes, please go ahead and make changes in my master. Thanks!

hjoliver commented 4 years ago

@prasannavijayan - thanks, I will take over from here, the final small tweaks should be easy for me now.

If you want more changes, please go ahead and make changes in my master.

I have a copy of your branch now, so I don't need to push changes to your master.

Sorry, I couldn't work on this on time.

No need to apologize, you did a great job :grinning: - thanks again :bouquet:

So, I will close this Pull Request soon (because I can't merge it directly to master in a functional state - there are still a few broken image URLs etc, so it would break the live web site) - but I'll ping you on the new PR which will consist of your commits (with your name on them!) plus my final tweaks. :+1: