search

cyllab / CalcUS

Quantum Chemistry Web Platform
https://calcus.readthedocs.io
GNU General Public License v3.0
65 stars 19 forks source link

Enabled Navbar utility on IPads and Tablets #6

Closed ForchaGlen closed 1 year ago

ForchaGlen commented 2 years ago

Enabled Navbar utility on IPads and Tablets by: -Commenting Out toggle class on navbar-burger

https://user-images.githubusercontent.com/101187353/159346216-146d5ee3-b630-4188-8990-2f5b7a30c7c7.mp4

RaphaelRobidas commented 2 years ago

Thanks for the PR,

I don't really see the difference this change makes. The navbar also opens with the line uncommented for me. Can you specify the change it makes?

ForchaGlen commented 2 years ago

Thanks for the PR,

I don't really see the difference this change makes. The navbar also opens with the line uncommented for me. Can you specify the change it makes?

I am sorry , uncommenting did not do the trick. The navbar instance of base.html is not working as expected. Please watch the video below while paying attention to the developer console.

https://user-images.githubusercontent.com/101187353/159408252-301f5822-1580-4096-ab51-fe3999cc3d04.mp4

I had to replace the to toggle class navbar-burger instance with navbar-menu.

ForchaGlen commented 2 years ago

Thanks for the PR, I don't really see the difference this change makes. The navbar also opens with the line uncommented for me. Can you specify the change it makes?

I am sorry , uncommenting did not do the trick. The navbar instance of base.html is not working as expected. Please watch the video below while paying attention to the developer console. result1.mp4

I had to replace the to toggle class navbar-burger instance with navbar-menu.

@RaphaelRobidas , please , I am in the right direction here ?

RaphaelRobidas commented 2 years ago

This is strange, because the navbar works for me with the current code and the iPad display format (in Firefox as well). What version of Firefox are you running? I am using version 91.5.0esr. Perhaps there was a small bug in earlier version of Firefox?

Because of this, your change doesn't quite make sense to me. You have the line $(".navbar-menu").toggleClass("is-active"); twice, which must toggle the is-active property on and then off again, effectively doing nothing? We need to investigate this issue further to see why the mobile navbar is not working in your case but it is working for me. This should lead us to a fix.

RaphaelRobidas commented 1 year ago

Closing due to inactivity.