cylondata / twister2

A composable framework for fast and scalable data analytics
https://twister2.org
Apache License 2.0
57 stars 32 forks source link

An external configuration to override the host ip #915

Closed DImuthuUpe closed 4 years ago

ahmet-uyar commented 4 years ago

Hi @chathurawidanage, this pull request looks good. It does not harm anything as you mentioned. I think @supunkamburugamuve was wondering whether we can have a better solution that will programmatically determine correct IP address for the job-master node.

One possibility solution may be to get all probably IP addresses for the job master node and send them to workers. Then, workers can try all of them. If any one of them reachable, they can connect with it to JM.

supunkamburugamuve commented 4 years ago

There is a maven dependency issue when building. I think the resource scheduler depends on comms package that causes the issue

DImuthuUpe commented 4 years ago

Closing due to merge conflicts. Will submit a new PR