search

cylondata / twister2

A composable framework for fast and scalable data analytics
https://twister2.org
Apache License 2.0
57 stars 32 forks source link

[MAJOR API CHANGE] Tset generic swap and removing input generics from computeTset #935

Closed nirandaperera closed 3 years ago

nirandaperera commented 4 years ago

  1. Swapping the generics order in TSets Previously TSets functions had generics as <O, I>. It is changed to <I, O>. (I= input type, O=output type). This is more in-line with other frameworks like Spark.

  2. Removed Input type generic from ComputeTsets. Previously the signature was ComputeTSet<O, I>. But input types do not serve any purpose for a TSet, because no subsequent communication operations, do not care how that TSet was created. So, the new signature was changed to ComputeTSet<O> that only follows output type. Same logic follows for SComputeTSet<O>, KeyedTSet<K, V> and SKeyedTSet<K, V>.

nirandaperera commented 4 years ago

Since this is a major API change, @pulasthi could you please double-check the beam examples? @vibhatha could you please double-check windowing examples?

nirandaperera commented 3 years ago

Replaced by #943