search

cymcsg / UltimateRecyclerView

A RecyclerView(advanced and flexible version of ListView in Android) with refreshing,loading more,animation and many other features.
Apache License 2.0
7.22k stars 1.43k forks source link

code bug #435

Open SwiftyWang opened 7 years ago

SwiftyWang commented 7 years ago

if (mPadding != -1.1f) { mRecyclerView.setPadding(mPadding, mPadding, mPadding, mPadding); } else { mRecyclerView.setPadding(mPaddingLeft, mPaddingTop, mPaddingRight, mPaddingBottom); }

but mPadding is an integer it always not equals -1.1...

SwiftyWang commented 7 years ago

and also for the dismiss loadmore view if no more data, after read the source code I think if (mRecyclerView.isLoadMoreEnabled()) { mRecyclerView.disableLoadmore(); mAdapter.internalExecuteLoadingView(); } is better than hardcode to notifyItemRemoved. But if there is an api to do this is better.