search

cyndis / qmlrs

QtQuick interface for Rust
Apache License 2.0
437 stars 43 forks source link

Build fixes #42

Closed miv-ableton closed 8 years ago

miv-ableton commented 8 years ago

Some small fixes that I discovered while trying to build qmlrs. Please read each commit description and cherry-pick which changes you want. Let me know if you have any questions. Thanks!

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 96.774% when pulling cb621e984cd966ca7995c9a68c2500a4e9bd4999 on miv-ableton:BuildFixes into eba711da79b98b512a20a3366c545f94c92d3cf5 on cyndis:master.

florianjacob commented 8 years ago

@tpickett66 could you have a look at https://github.com/cyndis/qmlrs/pull/42/commits/cb621e984cd966ca7995c9a68c2500a4e9bd4999 and sign it off, as I can't say much about MacOSX specifics? Everything else looks fine to me, thanks! :sparkles:

tpickett66 commented 8 years ago

I'll take a look this evening.

On Fri, Apr 1, 2016, 12:46 PM florianjacob notifications@github.com wrote:

@tpickett66 https://github.com/tpickett66 could you have a look at cb621e9 https://github.com/cyndis/qmlrs/pull/42/commits/cb621e984cd966ca7995c9a68c2500a4e9bd4999 and sign it off, as I can't say much about MacOSX specifics? Everything else looks fine to me, thanks! [image: :sparkles:]

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/cyndis/qmlrs/pull/42#issuecomment-204515081

tpickett66 commented 8 years ago

Sorry, I didn't get to this sooner; everything looks good to me.

florianjacob commented 8 years ago

Not a problem, we all offer our precious free time here. :wink: