search

cynicaloptimist / improved-initiative

Combat tracker for Dungeons and Dragons (D&D) 5th Edition
https://www.patreon.com/improvedinitiative
MIT License
310 stars 108 forks source link

Minus key unusable for some during player suggested damage/healing in player view #419

Open Diffus3d opened 5 years ago

Diffus3d commented 5 years ago

For some folks on their phones/tablets they are unable to use/see a 'minus' symbol so they cannot suggest healing using this epic initiative feature. Weirdly it shows up on player suggested tags.

cynicaloptimist commented 5 years ago

What sort of phones have this issue? This is a weird one, as far as I know both Android and IOS will display a minus sign for numeric inputs.

Diffus3d commented 5 years ago

Galaxy S8 Model SM-G950U1 Running Android v9, Kernel 4.4.153 Using Chrome

However another user has an S8 and does not have the problem. Galaxy S8 Android v9.4.00.45 Uses Samsung Browser

So, maybe a Chrome + Samsung bug?

DevMyron commented 5 years ago

Mine is a Samsung Galaxy S7 edge Model: SM-G935V Running Android 8.0.0

When I go to input damage/healing I get what looks like a ten key set of buttons UI. It also has a decimal, but no plus or minus symbol. Its the same type of UI that would show up for my phone if I was entering information to a numbers only field.

Let me know if there is any more info you need and hope this helps.

Thanks so much for making this!

Diffus3d commented 5 years ago

If it helps, I think the issue is very similar to this one here: https://stackoverflow.com/questions/21677695/input-type-number-not-possible-to-insert-negative-numbers-on-mobile-phone

cynicaloptimist commented 4 years ago

It looks like this is a design issue with Samsung phones. I'd accept a pull request to fix this, perhaps by adding a small +/- button to the prompt itself.

Diffus3d commented 4 years ago

It looks like the problem won't occur on Samsung browser, so the workaround could simply be to make sure to use samsung browser on those phones. Since our players switched to it, there's no issue.

sasafras0818 commented 4 years ago

Some of my players have the same issue. Work around works however it would definitely be more convenient if they were able to use their preferred browser.