search

cynkra / constructive

Display Idiomatic Code to Construct Most R Objects
https://cynkra.github.io/constructive
Other
131 stars 6 forks source link

Improve extension system #412

Closed moodymudskipper closed 5 months ago

moodymudskipper commented 5 months ago

We have methods for classes as before but these methods are generics themselves, dispatched on the constructor. We also have distinct constructors for the atomic types, though opt_atomic() can still be used. Still needs the vignette to be updated before merging.

aviator-app[bot] commented 5 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
moodymudskipper commented 5 months ago

Closes #260

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 72.64151% with 290 lines in your changes missing coverage. Please review.

Project coverage is 77.77%. Comparing base (11b4b56) to head (c9d4eae). Report is 1 commits behind head on main.

:exclamation: Current head c9d4eae differs from pull request most recent head b865fb7

Please upload reports for the commit b865fb7 to get more accurate results.

Files Patch % Lines
R/s3-complex.R 0.00% 74 Missing :warning:
R/s3-raw.R 0.00% 40 Missing :warning:
R/s3-integer.R 57.14% 18 Missing :warning:
R/s3-POSIXct.R 21.42% 11 Missing :warning:
R/s3-logical.R 73.80% 11 Missing :warning:
R/character-helpers.R 90.52% 9 Missing :warning:
R/s3-ggplot2-simpleUnit.R 0.00% 9 Missing :warning:
R/s3-ggplot2-rel.R 0.00% 6 Missing :warning:
R/s3-mts.R 0.00% 6 Missing :warning:
R/s3-formula.R 72.22% 5 Missing :warning:
... and 60 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #412 +/- ## ========================================== - Coverage 81.81% 77.77% -4.05% ========================================== Files 102 109 +7 Lines 2541 3667 +1126 ========================================== + Hits 2079 2852 +773 - Misses 462 815 +353 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.