compression conflates NAs and NaNs

cynkra / constructive

Display Idiomatic Code to Construct Most R Objects

https://cynkra.github.io/constructive

Other

131 stars 6 forks source link

compression conflates NAs and NaNs #418

Closed moodymudskipper closed 5 months ago

moodymudskipper commented 5 months ago

worth checking all instances of is.na() in the package and replace with a stricter helper is.NA

constructive::construct(c(NA, NaN, NA))
#> {constructive} couldn't create code that reproduces perfectly the input
#> ℹ Call `construct_issues()` to inspect the last issues
#> rep(NA_real_, 3L)

^{Created on 2024-06-23 with reprex v2.1.0}

moodymudskipper commented 5 months ago

let's rather have is_na_real() and is_na_complex()