cynkra / constructive

Display Idiomatic Code to Construct Most R Objects
https://cynkra.github.io/constructive
Other
131 stars 6 forks source link

methods are not exported the right way #422

Closed moodymudskipper closed 5 months ago

moodymudskipper commented 5 months ago

We find in the NAMESPACE for instance:

S3method(.cstr_construct,CoordCartesian.coord_cartesian)

But we want :

S3method(.cstr_construct,CoordCartesian) S3method(.cstr_construct.CoordCartesian,coord_cartesian)

vctrs do some double dispatch so we could see how they make it work

The package still works though, prob due to S3 dispatch checking locally before checking the db, but this creates a note on older versions, and better set things straight.