search

cynkra / cynkrablog

Source of the cynkra blog
https://cynkra.com/blog
0 stars 1 forks source link

add deploy workflow #23

Closed maelle closed 11 months ago

maelle commented 1 year ago

Fix #16

maelle commented 1 year ago

Error: ! error in pak subprocess Caused by error in verify_extracted_package(filename, pkg_cache): ! '/tmp/RtmpQzyleV/file8d56bb9cc85/base64enc_0.1-3_R_x86_64-pc-linux-gnu.tar.gz' is not a valid R package, it is an empty archive

I need to remember where I last saw this error.

christophsax commented 1 year ago

@maelle This is still open, right? Please let me know if you need anything.

maelle commented 1 year ago

@krlmlr did you want to experiment with a pull workflow from cynkraweb? https://github.com/cynkra/cynkrablog/issues/16#issuecomment-1764302248

But how would previews work?

christophsax commented 1 year ago

@krlmlr Intuitievely, two separate workflows make sense to me. The goal here is to have a much faster turnover than for the website, and disentangling some of the processes looks like a good idea.

maelle commented 1 year ago

Blocker: https://github.com/cynkra/cynkrablog/issues/26

github-actions[bot] commented 1 year ago

Summary

Status Count
🔍 Total 812
✅ Successful 772
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 39
❓ Unknown 0
🚫 Errors 1

Errors per input

Errors in docs/blog/posts/2020-11-02-jitsi-load-balanced/index.html

maelle commented 1 year ago

I'll fix the links later.

maelle commented 1 year ago

@christophsax the blockers are the two comments I added to the diff.

maelle commented 11 months ago

I think the PR should include a WF logic for a preview environment. Either using quarto-dev/quarto-actions@main/publish#github-pages or cynkra/cynkraweb@695d92f/.github/workflows/s3-push.yaml#L193-L203

I am not sure I follow. I thought neither the preview nor the publication would use gh-pages? What should be the difference between the two cases?

Thank you!

pat-s commented 11 months ago

I've created a cynkraweb-blog S3 bucket and a corresponding Cloudfront instance. WRT to the preview workflow and bucket access in general, there are the following options:

pat-s commented 11 months ago

I am not sure I follow. I thought neither the preview nor the publication would use gh-pages? What should be the difference between the two cases?

This decision is up to you.

maelle commented 11 months ago

Ok, let me try tweaking a bit before I hand the workflow to you, thanks for your patience.

I am in favor of a public repo, especially for the typo fix PRs, and maybe later we could add commenting via discussions which could be nice.

maelle commented 11 months ago

I made one more commit, I can work on this again later this week @pat-s based on your feedback. Thanks a lot!

maelle commented 11 months ago

@pat-s does this mean that if we merge this creates the blog?

How does the redirect from cynkra.com/blog to this work?

pat-s commented 11 months ago

does this mean that if we merge this creates the blog?

Unless you comment out the publish part to s3, yes

How does the redirect from cynkra.com/blog to this work?

Not yet implemented. This should be done last when everything is really done. But blog.cynkra.com shouldn't be published too early either as otherwise there are two conflicting sites with the same content.

maelle commented 11 months ago

@christophsax we can merge but what are your non-negotiable regarding @pat-s' comment

This should be done last when everything is really done.

christophsax commented 11 months ago

We try to link this correctly as quick as possible. Let's merge for now. Thanks a lot!

pat-s commented 11 months ago

My comments were aimed at waiting with the final merge as now we have two sites being index with the same content without having the redirection in place and everything fully done.

It's not a dilemma, just clarifying what my intentions had been 😅 I'll add the redirection once #31 is done

maelle commented 11 months ago

sorry!