cynkra / dm

Working with relational data models in R

https://dm.cynkra.com

Other

502 stars 49 forks source link

migrated the updated fonts solution from https://github.com/cynkra/cy… #2199

Closed talpitoo closed 2 months ago

talpitoo commented 9 months ago

…nkraweb/issues/662

aviator-app[bot] commented 9 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

talpitoo commented 9 months ago

@christophsax @maelle please see my other comment here https://github.com/cynkra/cynkratemplate/pull/52#issuecomment-1971718352

maelle commented 8 months ago

So, building this locally I can't see the text on the cheatsheet. Did the links to the files change in the meantime?

Steps

install.packages("pkgdown")
install.packages("pak")
install.packages("servr")
pak::pak()
devtools::install()
pkgdown::build_site()
servr::httw("docs")

talpitoo commented 8 months ago

@maelle i don't know where those links are coming from. This PR contains only 3 .woff2 URLs, e.g. https://cynkra.com/assets/css/fonts/1449009/b3ca2df2-7bee-4fc0-84cb-b029b99c3b61.woff2 but your screenshot points to S3. I am not aware of the deeper architecture or cross-referencing other repos, e.g. cynkratemplate if plays a role or not. Maybe it will be okay on production and the S3 URLs appear on local builds only? cc. @christophsax