dm_pixarfilms has unsatisfied constraints

library(dm, warn.conflicts = FALSE)
dm_examine_constraints(dm_pixarfilms())
#> ! Unsatisfied constraints:
#> • Table `pixar_films`: primary key `film`: has 1 missing values
#> • Table `pixar_people`: primary key `film`     , `role_type`: has duplicate values: Toy Story 4, Storywriter (8), Cars, Screenwriter (6), The Good Dinosaur, Storywriter (5), Brave, Screenwriter (4), Cars 3, Storywriter (4), …

^{Created on 2021-12-09 by the reprex package (v2.0.1)}

AFAII the missing film is for films TBA, in our case it's in 2023, so I don't believe it's a mistake. We could either :

remove the primary keys
remove the problematic records t
replace the NA with a new value

film is the most important key of the dm so the dm has little value without it. Removing the row seems the easiest. A problem is we don't match {pixarfilms}'s data anymore.

The second issue is simply because one can have several persons with the same role on a movie, so we might have no pk or a pk on all 3 columns. The key doesn't have any child table so removing it seems the best solution to me.

Both issues happened because dm_add_pk() was used with check = FALSE(default), so I'll use check=TRUE in the fixed version.

cynkra / dm

dm_pixarfilms has unsatisfied constraints #707