cynkra / fledge

Wings for your R packages: Streamline the process of versioning R packages and updating NEWS
https://fledge.cynkra.com
186 stars 11 forks source link

In configuration file, have a field for contributors not to be listed #351

Open maelle opened 2 years ago

maelle commented 2 years ago

So that the PR attribution only happens for "external" contributors.

krlmlr commented 2 years ago

I was hoping we could mix and match by the info stored in DESCRIPTION?

maelle commented 2 years ago

Maybe but in DESCRIPTION there aren't GitHub usernames so one would need to make API calls based on email addresses, assuming all email addresses are listed in DESCRIPTION and users have public email addresses on GitHub (or use the same email address for their commits / don't make commits from the GitHub interface). With a configuration (that could actually live in DESCRIPTION as you once said IIRC), yes sadly author info is stored in two places but at least fledge does not need to make API calls? :sweat_smile:

krlmlr commented 2 years ago

Can we fuzzy-match by full name?

I'd like to see a compelling set of use cases that warrant a dedicated configuration file.

maelle commented 2 years ago

Wouldn't the configuration of conventional commits types (abbreviations, ordering, hiding) be nice? :innocent:

maelle commented 2 years ago

I really wish one could store GitHub username in DESCRIPTION in a standard way :thinking:

krlmlr commented 2 years ago

Does r-universe know?

maelle commented 2 years ago

The matching happens by email address https://github.com/r-universe-org/help#how-to-link-a-maintainer-email-addresses-to-a-username-on-r-universe=

maelle commented 1 year ago

@krlmlr this issue is how we could exclude GitHub Actions users.

krlmlr commented 1 year ago

We could use person(comment = c(github = "krlmlr")) .