search

cynkra / munch

Functions for working with the historicized list of communes of Switzerland.
https://munch.cynkra.com
6 stars 2 forks source link

Fix CI/CD #39

Closed krlmlr closed 3 years ago

krlmlr commented 3 years ago

I changed cantons to get_cantons(), need to clean up.

TSchiefer commented 3 years ago

One problem with the check is:

❯ checking installed package size ... NOTE
    installed size is 18.8Mb
    sub-directories of 1Mb or more:
      csv  18.1Mb

Can we do anything about this? Maybe store as zip?

krlmlr commented 3 years ago

Please add error_on <- "warning" to R-CMD-check.yaml for now.

krlmlr commented 3 years ago

And also to ...-dev.yaml .

TSchiefer commented 3 years ago

in R/get_merger_mapping_table.R we have this:

  if (Sys.getenv("IN_PKGDOWN") == "") {
    readr::write_csv(mutation_init, new_csv_file("debug-init", end_year))
  }

and one for debug-base.

do we still need this? (leads to an error in the R-CMD-check)

krlmlr commented 3 years ago

I think we can remove it for now, also the files.

TSchiefer commented 3 years ago

There is now one check failing, on ubuntu-18.04 (devel). No idea why the example fails in this case whereas it works fine in all other setups. If you think we should investigate that it would be nice if you could give me a pointer how to tackle this. If we can ignore this one failed case, I would consider this issue done.

krlmlr commented 3 years ago

This looks odd. Can you please add build matrix entries for R-devel on macOS and Windows, to investigate if this occurs across platforms?

TSchiefer commented 3 years ago

Occurs across platforms

krlmlr commented 3 years ago

I can replicate locally with R devel, will take a look.

github-actions[bot] commented 2 years ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.