cynkra / munch

Functions for working with the historicized list of communes of Switzerland.
https://munch.cynkra.com
6 stars 2 forks source link

function to download mun-list by year/date #42

Closed TSchiefer closed 3 years ago

TSchiefer commented 3 years ago

@krlmlr Would you say this is roughly what we want?

closes #19

codecov[bot] commented 3 years ago

Codecov Report

Merging #42 (e897075) into main (f900626) will decrease coverage by 0.53%. The diff coverage is 0.00%.

:exclamation: Current head e897075 differs from pull request most recent head 86d114d. Consider uploading reports for the commit 86d114d to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   37.73%   37.20%   -0.54%     
==========================================
  Files          16       17       +1     
  Lines         628      637       +9     
==========================================
  Hits          237      237              
- Misses        391      400       +9     
Impacted Files Coverage Δ
R/download_mun_list_by_year.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f900626...86d114d. Read the comment docs.

TSchiefer commented 3 years ago

Is this functions something to export?

krlmlr commented 3 years ago

Maybe export later? Let's think about an interface first and about the available datasets (population/area/shapefile).

TSchiefer commented 3 years ago

Ok, in this case I will just write a test or two and then I'd ask you for another review. The canton is now included in the resulting table and some errors are thrown in case of faulty input.

Earliest possible date to query is BTW 1848-09-12, the date of the first federal constitution :)

TSchiefer commented 3 years ago

dm would surely be an option.

Merging now.