search

cynkra / munch

Functions for working with the historicized list of communes of Switzerland.
https://munch.cynkra.com
6 stars 2 forks source link

tests #44

Closed TSchiefer closed 2 years ago

TSchiefer commented 3 years ago

closes #31

TSchiefer commented 3 years ago

think the Windows tests should now work with 4edd1bb -- currently failing due to https://chocolatey.org/api/v2/ being down for maintenance, checking later again.

TSchiefer commented 3 years ago

this seems ok now to me. I disabled tests/testthat/test-up-to-date.R on Windows, since it seems to have been that way also before it got broken completely. Now it again failed on Windows (e.g. https://github.com/cynkra/munch/pull/44/checks?check_run_id=2236574313), which I don't understand (or does it maybe have something to do with weird Windows-encoding?). Maybe we can fix it somehow or leave it disabled on Windows.

TSchiefer commented 3 years ago

I removed the obvious dependencies on {pkgload}; now I can't find any mention of {pkgload} anywhere, but the tests are still complaining that an apparent dependency isn't acknowledged.

krlmlr commented 3 years ago

It's tricky.

PRs are checked using a synthetic commit where the source branch is merged into the target branch: https://github.com/cynkra/munch/pull/44/checks?check_run_id=2237415606#step:3:394. The main branch was ahead and contained the evil pkgload line.

I think it's fine to use pkgload in the data-raw/ directory.

krlmlr commented 3 years ago

To recover, git reset --hard f809e25, force-push, and redo.

krlmlr commented 3 years ago

We really need to merge main into this branch to avoid losing our minds.

TSchiefer commented 3 years ago

Sorry for the mess... when I locally merge master main into this branch, no changes are the result. So I will let these checks finish, cause I haven't lost all hope that this will work now...

krlmlr commented 3 years ago

The main branch is called main.

krlmlr commented 3 years ago

...in this repo.

TSchiefer commented 3 years ago

you're right, I meant main; seems to be good now.

krlmlr commented 2 years ago

Thanks!